Support enableServiceLinks in PodSpec

[JPMoresmau]

Terraform Version

Terraform v0.12.7

• provider.kubernetes v1.10.0

Affected Resource(s)

• kubernetes_deployment
• kubernetes_pod

Expected Behavior

Have a way to use enable_service_links in a deployment/pod spec

Actual Behavior

An argument named "enable_service_links" is not expected here.

References

kubernetes/kubernetes#68754

Since environment variables can wreak havoc with some programs (most notably Apache Java apps), turning them off was requested.
Note that I can see enableServiceLinks in https://github.com/terraform-providers/terraform-provider-kubernetes/blob/master/vendor/k8s.io/api/core/v1/types_swagger_doc_generated.go

[abrzozowski-ITM]

StatefulSet is also affected.

[MathyV]

@aareet any chance of getting that PR reviewed?

[shd4]

Any updates on this? enableServiceLinks not being disabled produces a lot of pain...

[aareet]

The PR is waiting on an acceptance test being added.

[dak1n1]

It looks like we implemented this a while back but didn't update this issue. The enable_service_links option is present in the PodSpec now: https://registry.terraform.io/providers/hashicorp/kubernetes/latest/docs/resources/pod#enable_service_links

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!