Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kubernetes to v1.28.6 #2404

Merged
merged 3 commits into from
Jan 23, 2024
Merged

Update kubernetes to v1.28.6 #2404

merged 3 commits into from
Jan 23, 2024

Conversation

appilon
Copy link
Contributor

@appilon appilon commented Jan 18, 2024

Description

Update kubernetes and remove replace directives.

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc
...

Release Note

Release note for CHANGELOG:

Bump Kubernetes dependencies from x.27.8 to x.28.6.

References

N/A

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Update kubernetes and remove replace directives.
@arybolovlev
Copy link
Contributor

Can you please add a changelog file .changelog/2404.txt to reflect the changes in this PR in the upcoming release note?

Something like this:

```release-note:note
Bump Kubernetes dependencies from x.27.8 to x.28.6.
```

Thanks!

@appilon appilon marked this pull request as ready for review January 19, 2024 20:43
@appilon appilon requested a review from a team as a code owner January 19, 2024 20:43
@appilon
Copy link
Contributor Author

appilon commented Jan 19, 2024

@arybolovlev I ran the tests locally against a manually pinned k8s 1.28 cluster in kind. I was going to pin the version in the PR, but then I realized it seems like the kind version can be set as an input variable in GH actions, and this is sort of the defacto way of setting the version of the k8s cluster. Problem is kind 0.21 is not released yet so the acceptance tests can't currently be set to k8s 1.28.

@arybolovlev
Copy link
Contributor

@arybolovlev I ran the tests locally against a manually pinned k8s 1.28 cluster in kind. I was going to pin the version in the PR, but then I realized it seems like the kind version can be set as an input variable in GH actions, and this is sort of the defacto way of setting the version of the k8s cluster. Problem is kind 0.21 is not released yet so the acceptance tests can't currently be set to k8s 1.28.

That is fine. They are backward compatible anyway. This issue with KinD will be fixed soon too. In the meantime, AKS, EKS, and GKE run on 1.28, you can run them manually or wait for the next day after the merge, and they will be run nightly.

Thanks!

Copy link
Contributor

@arybolovlev arybolovlev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Alex! 🚀

@appilon
Copy link
Contributor Author

appilon commented Jan 23, 2024

@arybolovlev Do i need to bump the default version of k8s for the GKE/AWS/Azure clusters? I see 1.27 referenced as the default in a few places?

UPDATE: seems like the version is mainly maintained through GH actions itself, going to just merge

@appilon appilon merged commit c04862b into main Jan 23, 2024
30 checks passed
@appilon appilon deleted the appilon/bump-kubernetes branch January 23, 2024 15:18
dduportal referenced this pull request in jenkins-infra/azure Feb 19, 2024
<Actions>
<action
id="bcd9b70d7c1eb1e07eb5ad8a958f18dc1bbd81461ee1a2604adeea46e3148a47">
        <h3>Bump Terraform `kubernetes` provider version</h3>
<details
id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24">
            <summary>Update Terraform lock file</summary>
<p>changes detected:&#xA;&#x9;&#34;hashicorp/kubernetes&#34; updated
from &#34;2.25.2&#34; to &#34;2.26.0&#34; in file
&#34;.terraform.lock.hcl&#34;</p>
            <details>
                <summary>2.26.0</summary>
<pre>Changelog retrieved
from:&#xA;&#x9;https://github.com/hashicorp/terraform-provider-kubernetes/releases/tag/v2.26.0&#xA;ENHANCEMENTS:&#xA;&#xA;*
`kubernetes/kubernetes_deployment_v1`: Add support for `HugePages` in
`emptyDir.medium`
[[GH-2395](https://github.com/hashicorp/terraform-provider-kubernetes/issues/2395)]&#xA;*
`resource/kubernetes_job_v1`: add new attribute
`spec.pod_failure_policy` to job spec
[[GH-2394](https://github.com/hashicorp/terraform-provider-kubernetes/issues/2394)]&#xA;&#xA;NOTES:&#xA;&#xA;*
Bump Kubernetes dependencies from x.27.8 to x.28.6.
[[GH-2404](https://github.com/hashicorp/terraform-provider-kubernetes/issues/2404)]&#xA;&#xA;&#xA;</pre>
            </details>
        </details>
<a
href="https://infra.ci.jenkins.io/job/updatecli/job/azure/job/main/3/">Jenkins
pipeline link</a>
    </action>
</Actions>

---

<table>
  <tr>
    <td width="77">
<img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli
logo" width="50" height="50">
    </td>
    <td>
      <p>
Created automatically by <a
href="https://www.updatecli.io/">Updatecli</a>
      </p>
      <details><summary>Options:</summary>
        <br />
<p>Most of Updatecli configuration is done via <a
href="https://www.updatecli.io/docs/prologue/quick-start/">its
manifest(s)</a>.</p>
        <ul>
<li>If you close this pull request, Updatecli will automatically reopen
it, the next time it runs.</li>
<li>If you close this pull request and delete the base branch, Updatecli
will automatically recreate it, erasing all previous commits made.</li>
        </ul>
        <p>
Feel free to report any issues at <a
href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br
/>
If you find this tool useful, do not hesitate to star <a
href="https://github.com/updatecli/updatecli/stargazers">our GitHub
repository</a> as a sign of appreciation, and/or to tell us directly on
our <a
href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>!
        </p>
      </details>
    </td>
  </tr>
</table>

Co-authored-by: Jenkins Infra Bot (updatecli) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants