New modelV1 for resource/http

Earlier it was using modelV1 which also changed docs for data-source
Introduced new modelV1 with when attribute for resource http

Author: Prajwal-Shah

docs/data-sources/http.md

@@ -157,7 +157,6 @@ resource "null_resource" "example" {
 - `request_headers` (Map of String) A map of request header field names and values.
 - `request_timeout_ms` (Number) The request timeout in milliseconds.
 - `retry` (Block, Optional) Retry request configuration. By default there are no retries. Configuring this block will result in retries if an error is returned by the client (e.g., connection errors) or if a 5xx-range (except 501) status code is received. For further details see [go-retryablehttp](https://pkg.go.dev/github.com/hashicorp/go-retryablehttp). (see [below for nested schema](#nestedblock--retry))
-- `when` (String) When to send the HTTP request. Valid values are `apply` (default) and `destroy`. When set to `apply`, the request is sent during resource creation and updates. When set to `destroy`, the request is only sent during resource destruction. This attribute is only applicable to the http resource, not the data source.
 
 ### Read-Only
 

internal/provider/data_source_http.go

@@ -160,20 +160,6 @@ a 5xx-range (except 501) status code is received. For further details see
 				Optional:    true,
 			},
 
-			"when": schema.StringAttribute{
-				Description: "When to send the HTTP request. Valid values are `apply` (default) and `destroy`. " +
-					"When set to `apply`, the request is sent during resource creation and updates. " +
-					"When set to `destroy`, the request is only sent during resource destruction. " +
-					"This attribute is only applicable to the http resource, not the data source.",
-				Optional: true,
-				Validators: []validator.String{
-					stringvalidator.OneOf([]string{
-						"apply",
-						"destroy",
-					}...),
-				},
-			},
-
 			"response_headers": schema.MapAttribute{
 				Description: `A map of response header field names and values.` +
 					` Duplicate headers are concatenated according to [RFC2616](https://www.w3.org/Protocols/rfc2616/rfc2616-sec4.html#sec4.2).`,
@@ -442,7 +428,6 @@ type modelV0 struct {
 	RequestBody        types.String `tfsdk:"request_body"`
 	RequestTimeout     types.Int64  `tfsdk:"request_timeout_ms"`
 	Retry              types.Object `tfsdk:"retry"`
-	When               types.String `tfsdk:"when"`
 	ResponseHeaders    types.Map    `tfsdk:"response_headers"`
 	CaCertificate      types.String `tfsdk:"ca_cert_pem"`
 	ClientCert         types.String `tfsdk:"client_cert_pem"`

internal/provider/resource_http.go

@@ -222,7 +222,7 @@ func (r *httpResource) Configure(ctx context.Context, req resource.ConfigureRequ
 }
 
 func (r *httpResource) Create(ctx context.Context, req resource.CreateRequest, resp *resource.CreateResponse) {
-	var model modelV0
+	var model modelV1
 	diags := req.Plan.Get(ctx, &model)
 	resp.Diagnostics.Append(diags...)
 	if resp.Diagnostics.HasError() {
@@ -258,7 +258,7 @@ func (r *httpResource) Create(ctx context.Context, req resource.CreateRequest, r
 }
 
 func (r *httpResource) Read(ctx context.Context, req resource.ReadRequest, resp *resource.ReadResponse) {
-	var model modelV0
+	var model modelV1
 	diags := req.State.Get(ctx, &model)
 	resp.Diagnostics.Append(diags...)
 	if resp.Diagnostics.HasError() {
@@ -292,7 +292,7 @@ func (r *httpResource) Read(ctx context.Context, req resource.ReadRequest, resp
 
 func (r *httpResource) Update(ctx context.Context, req resource.UpdateRequest, resp *resource.UpdateResponse) {
 	// Preserve computed fields across updates; reflect config changes and optionally perform request
-	var plan, state modelV0
+	var plan, state modelV1
 	var diags diag.Diagnostics
 
 	// Read desired configuration from plan
@@ -336,7 +336,7 @@ func (r *httpResource) Update(ctx context.Context, req resource.UpdateRequest, r
 }
 
 func (r *httpResource) Delete(ctx context.Context, req resource.DeleteRequest, resp *resource.DeleteResponse) {
-	var model modelV0
+	var model modelV1
 	diags := req.State.Get(ctx, &model)
 	resp.Diagnostics.Append(diags...)
 	if resp.Diagnostics.HasError() {
@@ -356,7 +356,7 @@ func (r *httpResource) Delete(ctx context.Context, req resource.DeleteRequest, r
 	}
 }
 
-func (r *httpResource) performRequest(ctx context.Context, model *modelV0, diags *diag.Diagnostics) error {
+func (r *httpResource) performRequest(ctx context.Context, model *modelV1, diags *diag.Diagnostics) error {
 	requestURL := model.URL.ValueString()
 	method := model.Method.ValueString()
 	requestHeaders := model.RequestHeaders
@@ -555,3 +555,23 @@ func (r *httpResource) performRequest(ctx context.Context, model *modelV0, diags
 
 	return nil
 }
+
+type modelV1 struct {
+	ID                 types.String `tfsdk:"id"`
+	URL                types.String `tfsdk:"url"`
+	Method             types.String `tfsdk:"method"`
+	RequestHeaders     types.Map    `tfsdk:"request_headers"`
+	RequestBody        types.String `tfsdk:"request_body"`
+	RequestTimeout     types.Int64  `tfsdk:"request_timeout_ms"`
+	Retry              types.Object `tfsdk:"retry"`
+	When               types.String `tfsdk:"when"`
+	ResponseHeaders    types.Map    `tfsdk:"response_headers"`
+	CaCertificate      types.String `tfsdk:"ca_cert_pem"`
+	ClientCert         types.String `tfsdk:"client_cert_pem"`
+	ClientKey          types.String `tfsdk:"client_key_pem"`
+	Insecure           types.Bool   `tfsdk:"insecure"`
+	ResponseBody       types.String `tfsdk:"response_body"`
+	Body               types.String `tfsdk:"body"`
+	ResponseBodyBase64 types.String `tfsdk:"response_body_base64"`
+	StatusCode         types.Int64  `tfsdk:"status_code"`
+}