Add support for the rest of the AutoprovisioningNodePoolDefaults settings in google_container_cluster

[pib]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

AutoprovisioningNodePoolDefaults in the v1 API has support for several more fields than those currently supported by the auto_provisioning_defaults block.

Currently only min_cpu_platform, oauth_scopes, and service_account are supported.

Options currently missing are

• upgradeSettings
• management
• diskSizeGb
• diskType
• shieldedInstanceConfig
• bootDiskKmsKey

It might makes sense for these to be implemented in separate PRs. There are already a couple of existing PRs that add upgrade_settings and management (linked in the references section below).

New or Affected Resource(s)

• google_container_cluster

Potential Terraform Configuration

resource "google_container_cluster" "example" {
  name = "example"

  cluster_autoscaling {
    enabled = true

    auto_provisioning_defaults {
      service_account  = google_service_account.cluster_nodes_service_account.email
      min_cpu_platform = "Intel Haswell"
      oauth_scopes     = []

      # New options
      upgrade_settings {
        max_surge       = "25%"
        max_unavailable = "0"
      }

      management {
        auto_repair  = true
        auto_upgrade = true
      }

      disk_size_gb      = 12
      disk_type         = "pd-ssd"
      boot_disk_kms_key = google_kms_crypto_key.example.id

      shielded_instance_config {
        enable_secure_boot          = true
        enable_integrity_monitoring = false
      }
    }
  }
}

References

• Add support for upgrade_settings in google_container_cluster NAP #5580 (request for upgrade_settings), add support for upgrade_settings in both node config and NAP config #5676 (PR for that feature)
• Add support for management settings in google_container_cluster NAP #5579 (request for management block), add support for management settings in google_container_cluster NAP #5672 (PR for that feature)
• b/189224778

[dippynark]

Should default node image type be included in this list? https://cloud.google.com/kubernetes-engine/docs/how-to/node-auto-provisioning#default-image-type

[YpNo]

Hi,
I need the missing options as well with a focus on image_type.

Regards.

[rafaeljesus]

Any idea when these features will be available? I can't enable NAP due to this limitation as well

[mitj04]

All the PRs have been merged for requested attributes. Hence, we can close this issue. Feel free to reach out if there are any remaining attributes. Thanks!

Below are the PRs for the requested attributes:

• shieldedInstanceConfig: #PR-6754
• management: #PR-6794
• upgradeSettings and minCpuPlatform: #PR-6815
• bootDiskKmsKey: #PR-6323
• diskSizeGb and diskType: #PR-6649

b/189224778

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.