Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move DefaultFunc logic to configure section #8876

Comments

@megan07
Copy link
Contributor

megan07 commented Apr 8, 2021

Background: Running the configured provider when access_token is a static value and credentials are set by an env variable fails, it seems the test only succeeded previously because access_token was set to an unknown resource attribute. And it fails with 0.15 because there is a new change that validates the complete configuration before configuring the provider.

In this case it seems like an explicitly-set access_token should override a defaulted credentials, but we aren't sure that assumption should be generalized for all ConflictsWith/DefaultFunc situations. So the suggestion was that maybe we leave DefaultFunc unset and handle the environment variables directly inside Configure instead.

We'll need to review the precedence of access_token and credentials after the logic is moved into Configure. This will be a breaking change so we will address it in 4.0.0

Failed test: https://ci-oss.hashicorp.engineering/buildConfiguration/GoogleCloud_ProviderGoogleCloudGoogleProject/180134?showLog=180134_209134_208405.208416.209134&logFilter=debug

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.