Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support labels for Bigtable Instance #6813

Closed
caieo opened this issue Jul 20, 2020 · 3 comments · Fixed by GoogleCloudPlatform/magic-modules#3793, #6890, #6921 or hashicorp/terraform-provider-google-beta#2325

Comments

@caieo
Copy link

caieo commented Jul 20, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

It looks like a newer version of Bigtable Instance supports labels (https://cloud.google.com/bigtable/docs/reference/admin/rest/v2/projects.instances#Instance), but the Terraform provider does not (https://www.terraform.io/docs/providers/google/r/bigtable_instance.html).

New or Affected Resource(s)

  • google_bigtable_instance

Potential Terraform Configuration

N/A

References

@rileykarson
Copy link
Collaborator

The magic words fix #6813 in a vendoring change closed this. Sorry for the noise!

@ryanyuan
Copy link
Contributor

cool. thank you @rileykarson

@ghost
Copy link

ghost commented Sep 3, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.