Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BigTable instance labeling #5017

Closed
Shanjohn opened this issue Nov 28, 2019 · 2 comments
Closed

Add BigTable instance labeling #5017

Shanjohn opened this issue Nov 28, 2019 · 2 comments

Comments

@Shanjohn
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

Right now after BigTable instance creation you have to manually set labels. The more convenient solution will be to set those labels in terraform resource instead.

New or Affected Resource(s)

  • google_bigtable_instance

Potential Terraform Configuration

resource "google_bigtable_instance" "instance" {
  name   = "tf-instance"
  labels = {
    project = "Example project"
    environment = "QA"
  }

  cluster {
    cluster_id   = "tf-instance-cluster"
    zone         = "us-central1-b"
    num_nodes    = 3
    storage_type = "HDD"
  }
  
}
@ghost ghost added the enhancement label Nov 28, 2019
@danawillow danawillow added this to the Goals milestone Dec 2, 2019
@danawillow
Copy link
Contributor

Added in GoogleCloudPlatform/magic-modules#3793.

@ghost
Copy link

ghost commented Sep 3, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants