guest_accelerator with count of 0 forces node pool recreation (permadiff)

[morgante]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment
• If an issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If an issue is assigned to a user, that user is claiming responsibility for the issue. If an issue is assigned to "hashibot", a community member has claimed the issue already.

Terraform Version

Terraform v0.11.13

Affected Resource(s)

• google_container_cluster

Terraform Configuration Files

https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/master/cluster_regional.tf#L142

Steps to Reproduce

1. Create a node pool without a guest_accelerator block that has count 0.
2. Observe the permadiff:

      node_config.0.guest_accelerator.#:                      "0" => "1" (forces new resource)
      node_config.0.guest_accelerator.0.count:                "" => "0" (forces new resource)

A guest_accelerator block with a count of 0 should be interpreted the same as a non-existent guest_accelerator block (and certainly not force a node pool recreation).

References

• Forced recreating node_pool at any plan terraform-google-modules/terraform-google-kubernetes-engine#120

[chrisst]

I'm testing out a fix for this, but I wanted to make sure you were also aware that you can also remove the guest_accelerator block using the empty list syntax. eg: guest_accelerator = [].

This is because we have marked guest_accelerator as an "attribute as block". Anything identified as this in the docs will accept the empty list syntax to remove the whole block since omitting the block will assume that it is a computed value.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!