Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google_gke_hub_membership global location only? #15882

Closed
ghost opened this issue Sep 18, 2023 · 5 comments
Closed

google_gke_hub_membership global location only? #15882

ghost opened this issue Sep 18, 2023 · 5 comments

Comments

@ghost
Copy link

ghost commented Sep 18, 2023

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

When using the TF provider (google_gke_hub_membership) it seems that the location is fixed with global and no regional setup is possible like through the gc.loud CLI

New or Affected Resource(s)

google_gke_hub_membership

Potential Terraform Configuration

resource "google_gke_hub_membership" "gke_cluster" {
  project = "fleet_project_id"
  membership_id = "gke_cluster"
  location = "europe-west4"

  endpoint {
    gke_cluster {
      resource_link = "//container.googleapis.com/${data.google_container_cluster. gke_cluster.id}"
    }
  }
}

b/301066298

@ghost ghost added the enhancement label Sep 18, 2023
@github-actions github-actions bot added forward/review In review; remove label to forward service/gkehub labels Sep 18, 2023
@melinath
Copy link
Collaborator

We can add a location field with default: global.

@melinath melinath added this to the Goals milestone Sep 18, 2023
@melinath melinath removed the forward/review In review; remove label to forward label Sep 18, 2023
@sahsagar-google
Copy link

I am working on this.

@ghost
Copy link
Author

ghost commented Sep 19, 2023

@melinath & @sahsagar-google, thank you for picking this up that quickly!
If there is any ETA, please let me know, happy to test & give feedback if needed.

@ghost
Copy link
Author

ghost commented Nov 17, 2023

Has been added with version 5.1.0 of the provider, thx a lot!

@ghost ghost closed this as completed Nov 17, 2023
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 18, 2023
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants