Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing values for GKE monitoring config - components: google_container_cluster #15704

Assignees
Labels
Milestone

Comments

@jindrichskupa
Copy link

Terraform will perform the following actions:
  # module.gke_primary.google_container_cluster.primary will be updated in-place
  ~ resource "google_container_cluster" "primary" {
        id                          = "projects/xxxx/locations/europe-west4/clusters/gke-xxxx"
        name                        = "gke-xxxx"
        # (28 unchanged attributes hidden)
      ~ monitoring_config {
          ~ enable_components = [
              - "SYSTEM_COMPONENTS",
              - "APISERVER",
              - "SCHEDULER",
              - "CONTROLLER_MANAGER",
              - "STORAGE",
              - "POD",
              - "DEPLOYMENT",
              - "STATEFULSET",
              - "DAEMONSET",
              - "HPA",
            ]
            # (2 unchanged blocks hidden)
        }
        # (21 unchanged blocks hidden)
    }
Plan: 0 to add, 1 to change, 0 to destroy.

Description

Above are currently possible values for enable_components, but the provider validates only for 3 of them.

https://cloud.google.com/kubernetes-engine/docs/reference/rest/v1/projects.locations.clusters#Cluster.MonitoringComponentConfig

New or Affected Resource(s)

  • google_container_cluster

Potential Terraform Configuration

    resource "google_container_cluster" "primary" {
        id                          = "projects/xxxx/locations/europe-west4/clusters/gke-xxxx"
        name                        = "gke-xxxx"
        monitoring_config {
            enable_components = [
                "SYSTEM_COMPONENTS",
                "APISERVER",
                "SCHEDULER",
                "CONTROLLER_MANAGER",
                "STORAGE",
                "POD",
                "DEPLOYMENT",
                "STATEFULSET",
                "DAEMONSET",
                "HPA",
            ]
        }
    }

References

@github-actions github-actions bot added forward/review In review; remove label to forward service/container labels Sep 1, 2023
@DanielRieske
Copy link

Would gladly pick this issue up, I will add the PR shortly.

@rileykarson
Copy link
Collaborator

Note: We may want to remove the validation here, since the supported set has been updated a few times.

@chelseychen
Copy link

Thanks for the picking this up! This is a new feature launch for GKE (already public preview launched) and terraform support is part of our GA launch.

@github-actions
Copy link

github-actions bot commented Oct 6, 2023

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.