Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memorystore Redis should allow updates without instance re-creation #1548

Closed
pdecat opened this issue May 28, 2018 · 2 comments
Closed

Memorystore Redis should allow updates without instance re-creation #1548

pdecat opened this issue May 28, 2018 · 2 comments
Assignees
Labels

Comments

@pdecat
Copy link
Contributor

pdecat commented May 28, 2018

Memorystore Redis allows updating the following information without re-creating the instance:

  • displayName
  • labels
  • memorySizeGb
  • redisConfig (not yet implemented by the terraform provider)

https://cloud.google.com/memorystore/docs/redis/reference/rest/v1beta1/projects.locations.instances/patch

Terraform Version

# terraform version
Terraform v0.11.7
+ provider.external v1.0.0
+ provider.google v1.13.0
+ provider.template v1.0.0

Affected Resource(s)

  • google_redis_instance

Terraform Configuration Files

resource "google_redis_instance" "webfront" {
  name = "redis-myproject-euw1"

  tier           = "STANDARD_HA"
  memory_size_gb = "2" # Updated from 1

  region                  = "europe-west1"
  location_id             = "europe-west1-b"
  alternative_location_id = "europe-west1-d"

  redis_version     = "REDIS_3_2"
  reserved_ip_range = "10.0.0.0/29"
}

Expected Behavior

Changing memory_size_gb (or any other modifiable param) should update the existing instance and not require creating a new instance.

Actual Behavior

Changing memory_size_gb requires creating a new instance:

-/+ google_redis_instance.portal (new resource required)
      id:                      "myproject/europe-west1/redis-myproject-euw1" => <computed> (forces new resource)
      alternative_location_id: "europe-west1-d" => "europe-west1-d"
      authorized_network:      "projects/myproject/global/networks/myproject-net0" => <computed>
      create_time:             "2018-05-10T06:40:26.886844Z" => <computed>
      current_location_id:     "europe-west1-d" => <computed>
      host:                    "10.0.0.4" => <computed>
      location_id:             "europe-west1-b" => "europe-west1-b"
      memory_size_gb:          "1" => "2" (forces new resource)
      name:                    "redis-myproject-euw1" => "redis-myproject-euw1"
      port:                    "6379" => <computed>
      project:                 "myproject" => <computed>
      redis_version:           "REDIS_3_2" => "REDIS_3_2"
      region:                  "europe-west1" => "europe-west1"
      reserved_ip_range:       "10.0.0.0/29" => "10.0.0.0/29"
      tier:                    "STANDARD_HA" => "STANDARD_HA"
@pdecat
Copy link
Contributor Author

pdecat commented Jun 5, 2018

Thanks!

@ghost
Copy link

ghost commented Nov 18, 2018

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 18, 2018
@github-actions github-actions bot added forward/review In review; remove label to forward service/redis-instance labels Jan 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants