-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redis datasource not returning reserved_ip_range information #14154
Comments
It looks like it is because of the PR GoogleCloudPlatform/magic-modules#7429, reserved_ip_range variable returns null value. Instead of adding ignore read on reserved ip ranges, a diff suppress function could be a better option. |
Unassigning myself as I wasn't able to work on the diff suppression function last week |
+1 that this was caused by GoogleCloudPlatform/magic-modules#7429 The value returned from the API was different than the input. After a discussion, the Redis API team recommended dropping this from diff calculation and future calls. This had the unintended effect of removing it from the datasource & import, because we're now exclusively relying on the clientside value. That was a miss on our part. This isn't easy to resolve We could add a second field that displays the real value to add this back to the datasource. We can copy from the second field into the first field in the handwritten DS implementation, as well. |
Is there any progress on this? At the moment we have resorted to ignoring
|
Community Note
modular-magician
user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If an issue is assigned to a user, that user is claiming responsibility for the issue. If an issue is assigned tohashibot
, a community member has claimed the issue already.Terraform Version
Working version:
Version with bug:
Affected Resource(s)
data.google_redis_instance
no longer returning IP address rangeTerraform Configuration Files
We have this logic (this is the approach that @jamiezieziula shared in terraform-google-modules/terraform-google-memorystore#89):
For debugging purposes, we added this code:
Debug Output
Panic Output
Expected Behavior
Due to a limitation of the Memorystore API, we need to pass a network name as a string to the Memorystore module during initial creation, and then we need to use an IP address for subsequent invocations to avoid a drift problem. We described our approach here, and it has been working pretty well for us: terraform-google-modules/terraform-google-memorystore#89
Using 4.57.0, this code works well for us. However, the returned
reserved_ip_range
isnull
in 4.58.0 and 4.59.0. We believe that it may be related to the pull request that attempted to fix the issue: #13958In 4.57.0, the outputs show this data:
Actual Behavior
In 4.58.0 and 4.59.0, the outputs show this data:
Steps to Reproduce
I expect that you should be able to recreate this behavior by using the data source on any existing Redis instance. You should see that the
reserved_ip_range
variable is null.Important Factoids
References
b/299600768
The text was updated successfully, but these errors were encountered: