Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Resource: azurerm_express_route_circuit_authorization #992

Merged
merged 2 commits into from
Mar 22, 2018
Merged

New Resource: azurerm_express_route_circuit_authorization #992

merged 2 commits into from
Mar 22, 2018

Conversation

tombuildsstuff
Copy link
Contributor

Tests pass:

$ acctests azurerm TestAccAzureRMExpressRouteCircuitAuthorization_
=== RUN   TestAccAzureRMExpressRouteCircuitAuthorization_importBasic
--- PASS: TestAccAzureRMExpressRouteCircuitAuthorization_importBasic (132.66s)
=== RUN   TestAccAzureRMExpressRouteCircuitAuthorization_basic
--- PASS: TestAccAzureRMExpressRouteCircuitAuthorization_basic (137.73s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	270.416s

@tombuildsstuff
New Resource: azurerm_express_route_circuit_authorization
144dda5 
Tests pass:

```
$ acctests azurerm TestAccAzureRMExpressRouteCircuitAuthorization_
=== RUN   TestAccAzureRMExpressRouteCircuitAuthorization_importBasic
--- PASS: TestAccAzureRMExpressRouteCircuitAuthorization_importBasic (132.66s)
=== RUN   TestAccAzureRMExpressRouteCircuitAuthorization_basic
--- PASS: TestAccAzureRMExpressRouteCircuitAuthorization_basic (137.73s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	270.416s
```
@tombuildsstuff tombuildsstuff added this to the 1.3.1 milestone Mar 16, 2018
@tombuildsstuff tombuildsstuff requested review from a team and removed request for a team March 16, 2018 22:47
@tombuildsstuff
Copy link
Contributor Author

Tearing down my sample it appears we need to lock based on the express route circuit name, since we get this error:

* azurerm_express_route_circuit_authorization.test: Error deleting Express Route Circuit Authorization "tom-ercauth" (Circuit "tom-erc" / Resource Group "tom-devrg"): network.ExpressRouteCircuitAuthorizationsClient#Delete: Failure sending request: StatusCode=409 -- Original Error: failed request: autorest/azure: Service returned an error. Status=<nil> Code="AnotherOperationInProgress" Message="Another operation on this or dependent resource is in progress. To retrieve status of the operation use uri: https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/providers/Microsoft.Network/locations/westus/operations/464718aa-26dd-418f-bde8-660dd8b8f0b0?api-version=2017-09-01." Details=[]

when attempting to delete multiple authorizations at once. I'll push a fix next week..

@tombuildsstuff
Locking on the Express Route Circuit name
9c5a9f6 
Before these patches, this failed with:

```
* azurerm_express_route_circuit_authorization.test1: Error deleting Express Route Circuit Authorization "acctestauth12715900084028037607" (Circuit "acctest-erc-2715900084028037607" / Resource Group "acctestrg-2715900084028037607"): network.ExpressRouteCircuitAuthorizationsClient#Delete: Failure sending request: StatusCode=409 -- Original Error: failed request: autorest/azure: Service returned an error. Status=<nil> Code="AnotherOperationInProgress" Message="Another operation on this or dependent resource is in progress. To retrieve status of the operation use uri: https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/providers/Microsoft.Network/locations/eastus/operations/d30da8eb-3e09-480c-8844-745d73e0e8bd?api-version=2017-09-01." Details=[]
```

Now the tests pass:

```
$ acctests azurerm TestAccAzureRMExpressRouteCircuitAuthorization_multiple
=== RUN   TestAccAzureRMExpressRouteCircuitAuthorization_multiple
--- PASS: TestAccAzureRMExpressRouteCircuitAuthorization_multiple (781.75s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	781.781s
```
@tombuildsstuff tombuildsstuff requested a review from a team March 22, 2018 16:12
@tombuildsstuff
Copy link
Contributor Author

Tests pass:

screen shot 2018-03-22 at 19 48 53

@tombuildsstuff tombuildsstuff merged commit e9988cc into master Mar 22, 2018
@tombuildsstuff tombuildsstuff deleted the express-route-circuit-authorizations branch March 22, 2018 23:49
tombuildsstuff added a commit that referenced this pull request Mar 22, 2018
@tombuildsstuff
Updating to include #992
ee0156b
@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paultyng paultyng paultyng approved these changes

Assignees
No one assigned
Labels
new-resource service/express-route
Projects
None yet
Milestone
v1.3.1
Development

Successfully merging this pull request may close these issues.
2 participants
@tombuildsstuff @paultyng