Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ADLS File System to have ACLs added to the root #9917

Merged
merged 6 commits into from
Jan 27, 2021

Conversation

ross-p-smith
Copy link
Contributor

@ross-p-smith ross-p-smith commented Dec 17, 2020

This change allows the azurerm_storage_data_lake_gen2_filesystem resource to be configured with a set of ACE blocks that will be applied to the root "/" file system. This is needed as you require "--x" permission at the root if you are creating any azurerm_storage_data_lake_gen2_path resources.

The change has involved moving some of the validate/parse functions into shared code and apply the ACE functionality at the "/" path

This is to address Issue #9425

Fixes #9425

@jvanenckevort
Copy link

Excellent fix @ross-p-smith!

.devcontainer/devcontainer.json Outdated Show resolved Hide resolved
.devcontainer/Dockerfile Outdated Show resolved Hide resolved
@ross-p-smith
Copy link
Contributor Author

Thanks @favoretti - I have removed the files and will see if they can get reviewed under a separate PR

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @ross-p-smith

Thanks for this PR - apologies for the delayed review here!

Taking a look through on the whole this looks pretty good, if we can fix up the minor comments then this should otherwise be good to go 👍

Thanks!

ace["type"] = string(v.TagType)
if v.TagQualifier != nil {
ace["id"] = v.TagQualifier.String()
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the id field needs to be set to a value in all cases, else this'll show as a diff - so can we make this:

Suggested change
}
id := ""
if v.TagQualifier != nil {
id = v.TagQualifier.String()
}
ace["id"] = id

"ace": {
Type: schema.TypeList,
Optional: true,
Computed: true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can remove this, since this shouldn't be configured unless a user opts to do so:

Suggested change
Computed: true,

@@ -0,0 +1,69 @@
package parse
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor we're using the parse folder for Resource ID Parsers rather than for Schema -> Object parsing - could we move this back up a level

@tombuildsstuff
Copy link
Contributor

Chatting with @favoretti offline - @favoretti is going to send a follow-up PR to address these comments shortly so that we can get this in for this release, so I'll kick off the tests for this now - hope you don't mind @ross-p-smith

@tombuildsstuff
Copy link
Contributor

Tests pass:

Screenshot 2021-01-27 at 18 49 02

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in this comment - @favoretti is sending a follow up to fix the remaining comments so that we can get this in for this release

@tombuildsstuff tombuildsstuff merged commit 698386c into hashicorp:master Jan 27, 2021
@tombuildsstuff tombuildsstuff added this to the v2.45.0 milestone Jan 27, 2021
tombuildsstuff added a commit that referenced this pull request Jan 27, 2021
katbyte pushed a commit that referenced this pull request Jan 27, 2021
@ghost
Copy link

ghost commented Jan 28, 2021

This has been released in version 2.45.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.45.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Feb 27, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Feb 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Impossible to manage container root folder in Azure Datalake Gen2
4 participants