-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add partition_key_version attribute to resource azurerm_cosmosdb_sql_container #9496
Conversation
Test Result: ` ` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ankushjain3005 - overall this looks good, once the comments i've left inline are addressed (and testes pass) this should be good to merge!
azurerm/internal/services/cosmos/cosmosdb_sql_container_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/cosmos/cosmosdb_sql_container_resource.go
Outdated
Show resolved
Hide resolved
Co-authored-by: kt <[email protected]>
Pull from terraform-providers/terraform-provider-azurerm
resolved the comments and reran the test. here are the results $ TF_ACC=1 go test -v ./azurerm/internal/services/cosmos/ -run TestAccAzureRMCosmosDbSqlContainer -timeout 60m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc" === RUN |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ankushjain3005 - LGTM 👍
This has been released in version 2.40.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.40.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Azure Cosmos DB now supports large partition keys with values up to 2 KB. This pull request captures adding an attribute partition_key_version which can be used to set this configuration. This URL has more details about this.
This closes #8653.