Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Cosmos zone redundant update #9485

Merged
merged 2 commits into from
Nov 26, 2020
Merged

Conversation

kvendingoldo
Copy link
Contributor

@kvendingoldo kvendingoldo commented Nov 25, 2020

fixes #9463

@kvendingoldo
Copy link
Contributor Author

Test result:

TF_ACC=1 go test -v ./azurerm/internal/services/cosmos -run=TestAccAzureRMCosmosDBAccount_zoneRedundant_update_mongo -timeout 60m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccAzureRMCosmosDBAccount_zoneRedundant_update_mongo
=== PAUSE TestAccAzureRMCosmosDBAccount_zoneRedundant_update_mongo
=== CONT  TestAccAzureRMCosmosDBAccount_zoneRedundant_update_mongo
--- PASS: TestAccAzureRMCosmosDBAccount_zoneRedundant_update_mongo (2174.17s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/cosmos      2178.383s

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kvendingoldo - this LGTM 👍

@jackofallops jackofallops merged commit 85fff15 into hashicorp:master Nov 26, 2020
jackofallops added a commit that referenced this pull request Nov 26, 2020
@ghost
Copy link

ghost commented Nov 27, 2020

This has been released in version 2.38.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.38.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Dec 26, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_cosmosdb_account with zone_redundant = true errors on minor updates (e.g. change tags)
3 participants