Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add field for virtual network gateway and virtual network gateway connection #9330

Merged
merged 24 commits into from
Nov 26, 2020
Merged

add field for virtual network gateway and virtual network gateway connection #9330

merged 24 commits into from
Nov 26, 2020

Conversation

chenjianfei2017
Copy link
Contributor

No description provided.

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i've left some comments inline to address

@chenjianfei2017
Copy link
Contributor Author

@katbyte Thanks for your review! I changed the code according to your comments. pls help to review this pr.

@ghost ghost removed the waiting-response label Nov 19, 2020
@tombuildsstuff tombuildsstuff added this to the v2.38.0 milestone Nov 20, 2020
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM now 👍

@chenjianfei2017
Copy link
Contributor Author

@katbyte Could you pls help to merge this pr, I have no permission to merge, thx.

@katbyte
Copy link
Collaborator

katbyte commented Nov 26, 2020

Was waiting for tests to pass, they have now so merging!

@katbyte katbyte merged commit ddc2506 into hashicorp:master Nov 26, 2020
katbyte added a commit that referenced this pull request Nov 26, 2020
@ghost
Copy link

ghost commented Nov 27, 2020

This has been released in version 2.38.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.38.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Dec 26, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants