-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add proximity_placement_group_id
to AKS node pools
#9195
Add proximity_placement_group_id
to AKS node pools
#9195
Conversation
Fixes #9164 (make fmt reformatted images.html and security_center_auto_provisioning.html markdown, although I made no changes there)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @favoretti
Thanks for this PR :)
Taking a look through this is looking good, if we can fix up the minor comments then this otherwise LGTM 👍
Thanks!
azurerm/internal/services/containers/kubernetes_cluster_node_pool_data_source.go
Outdated
Show resolved
Hide resolved
Co-authored-by: Tom Harvey <[email protected]>
…ool_data_source.go Co-authored-by: Tom Harvey <[email protected]>
Co-authored-by: Tom Harvey <[email protected]>
Co-authored-by: Tom Harvey <[email protected]>
Co-authored-by: Tom Harvey <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for pushing those changes @favoretti
@favoretti looks like the PPG ID test fails due to an invalid config?
|
Ugh. I'll look into it in a bit and run acceptance here first too. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for pushing those changes @favoretti
Tests look good 👍 |
This has been released in version 2.36.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.36.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Fixes #9164
(make fmt reformatted images.html and
security_center_auto_provisioning.html markdown, although I made no
changes there)