Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_policy_definition resource and datasource can now look up builtin policy by name #9078

Merged
merged 2 commits into from
Oct 29, 2020

Conversation

Nepomuceno
Copy link
Contributor

Fixes #9074

Added the search by name into built in since it actually uses a different api so if the policy it is not found in the local ones get it from the built in ones.

@ghost ghost added the size/S label Oct 29, 2020
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THanks @Nepomuceno - This looks good to me 👍

@jackofallops
Copy link
Member

Tests passing (failures unrelated)
image

@jackofallops jackofallops changed the title correct the search by name to use built in too azurerm_policy_definition resource and datasource can now look up builtin policy by name Oct 29, 2020
@jackofallops jackofallops merged commit a91b4f6 into hashicorp:master Oct 29, 2020
jackofallops added a commit that referenced this pull request Oct 29, 2020
@ghost
Copy link

ghost commented Oct 29, 2020

This has been released in version 2.34.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.34.0"
}
# ... other configuration ...

@Nepomuceno Nepomuceno deleted the definition_data_source_name branch October 29, 2020 20:30
@ghost
Copy link

ghost commented Nov 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot get policy definition by name for built in policies
2 participants