Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for new-pod-scale-up for autoscaler profile on AKS #9008

Closed
alk-rniveau opened this issue Oct 23, 2020 · 4 comments · Fixed by #9291
Closed

Support for new-pod-scale-up for autoscaler profile on AKS #9008

alk-rniveau opened this issue Oct 23, 2020 · 4 comments · Fixed by #9291

Comments

@alk-rniveau
Copy link

alk-rniveau commented Oct 23, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

The new hidden parameter for autoscaler profile new-pod-scale-up (Azure/AKS#1716) is not yet supported by azurerm provider.

Do you plan to do it ?

New or Affected Resource(s)

azurerm_kubernetes_cluster

Potential Terraform Configuration

 auto_scaler_profile = {
    balance_similar_node_groups      = false
    max_graceful_termination_sec     = 600
    scale_down_delay_after_add       = "10m"
    scale_down_delay_after_delete    = "10s"
    scale_down_delay_after_failure   = "3m"
    scan_interval                    = "10s"
    scale_down_unneeded              = "1m"
    scale_down_unready               = "20m"
    scale_down_utilization_threshold = "0.5"
    new_pod_scale_up                 = "5m"
  }
@dstrebel
Copy link
Contributor

I can create a PR for this.

@tillepille
Copy link

@dstrebel @alk-rniveau
It would be awesome if the azurerm_kubernetes_cluster_node_pool resource would support this as well!

@tombuildsstuff tombuildsstuff added this to the v2.44.0 milestone Jan 14, 2021
@ghost
Copy link

ghost commented Jan 21, 2021

This has been released in version 2.44.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.44.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Feb 17, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Feb 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants