Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix azurerm_databricks_workspace.name validation #8997

Conversation

gplusplus314
Copy link
Contributor

Fixes #8924 . I also shored up the relevant unit test a bit. Code was written in a style to closely match the Azure Portal's validation prompts to keep it as simple as possible.

@ghost ghost added the size/M label Oct 23, 2020
@gplusplus314 gplusplus314 force-pushed the fix_databricks_workspace_resource_name_validation branch from 3a37dfb to 2ed4d27 Compare October 23, 2020 00:56
@gplusplus314 gplusplus314 marked this pull request as ready for review October 23, 2020 00:56
…vider-azurerm into fix_databricks_workspace_resource_name_validation
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gerryhernandez! LGTM 👍

@katbyte katbyte added this to the v2.34.0 milestone Oct 23, 2020
@katbyte katbyte merged commit 9f70ed7 into hashicorp:master Oct 23, 2020
katbyte added a commit that referenced this pull request Oct 23, 2020
@gplusplus314 gplusplus314 deleted the fix_databricks_workspace_resource_name_validation branch October 23, 2020 19:56
@ghost
Copy link

ghost commented Oct 29, 2020

This has been released in version 2.34.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.34.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Nov 23, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_databricks_workspace name validation is incorrect
2 participants