Add support for user assigned identities in AKS #8737
Conversation
Signed-off-by: flo_02_mu <[email protected]>
Signed-off-by: flo_02_mu <[email protected]>
flo-02-mu
changed the title
Signed-off-by: flo_02_mu <[email protected]>
|
The PR will become a lot smaller if the API upgrade is handled upfront, e.g. in #8982 |
|
@flo-02-mu working on addressing feedback on #8982 as we speak.. |
This comment has been minimized.
This comment has been minimized.
|
I believe the functionality went GA a few days ago. |
There was a problem hiding this comment.
LGTM, I suggest adding more validation and have provided a PR for it at flo-02-mu#1
@tombuildsstuff / @katbyte any chance of another review ❤️
| }, false), | ||
| }, | ||
| "user_assigned_identity_id": { | ||
| Type: schema.TypeString, | ||
| Optional: true, |
There was a problem hiding this comment.
there doesn't appear to be any validation for this actually being set,
I was able to submit this without and terraform started applying, I got this error back from the API:
Error: creating Managed Kubernetes Cluster "ss-demo-01-aks" (Resource Group "ss-demo-01-rg"): containerservice.ManagedClustersClient#CreateOrUpdate: Failure sending request: StatusCode=400 -- Original Error: Code="LinkedInvalidPropertyId" Message="Property id '' at path '' is invalid. Expect fully qualified resource Id that start with '/subscriptions/{subscriptionId}' or '/providers/{resourceProviderNamespace}/'."
on .terraform/modules/kubernetes/12-kubernetes-cluster.tf line 5, in resource "azurerm_kubernetes_cluster" "kubernetes_cluster":
5: resource "azurerm_kubernetes_cluster" "kubernetes_cluster" {
I've created a PR for this here: flo-02-mu#1
after my change you get:
Error: when `identity.type` is UserAssigned then `user_assigned_identity_id` must be set
on .terraform/modules/kubernetes/12-kubernetes-cluster.tf line 5, in resource "azurerm_kubernetes_cluster" "kubernetes_cluster":
5: resource "azurerm_kubernetes_cluster" "kubernetes_cluster" {
…rge-with-master Parse ID
There was a problem hiding this comment.
hey @flo-02-mu
Thanks for this PR - apologies for the delayed review here!
I've taken a look through and left some comments inline but if we can fix those up then this should be otherwise good to merge 👍
Thanks!
azurerm/internal/services/containers/kubernetes_cluster_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/containers/kubernetes_cluster_data_source.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/containers/kubernetes_cluster_validate.go
Outdated
Show resolved
Hide resolved
…igned-identities # Conflicts: # azurerm/internal/services/containers/kubernetes_cluster_data_source.go
|
This week’s, since its merged.
…On Tue, 19 Jan 2021 at 04:39, Srinath ***@***.***> wrote:
Hey guys any idea which milestone this is?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#8737 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGERNR3J6DL4IAWY5ITHR3S2T5GDANCNFSM4SDEUU7Q>
.
|
|
This has been released in version 2.44.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.44.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
This is an attempt to add support of user assigned identities in AKS as suggested in #7979
This is still a preview feature.
Fixes #7979