Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use IoT Hub API version 2020-03-01 instead 2019-03-22-preview #8688

Merged
merged 1 commit into from
Sep 30, 2020

Conversation

r0bnet
Copy link
Contributor

@r0bnet r0bnet commented Sep 30, 2020

There are some features missing (e.g. IdentityBased authentication of Iot Hub against Storage Account) in the current IoT Hub API version so I'd like to upgrade to newer one. Upgrade was painless.

@r0bnet r0bnet changed the title use API version 2020-03-01 instead 2019-03-22-preview Use IoT Hub API version 2020-03-01 instead 2019-03-22-preview Sep 30, 2020
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff added this to the v2.30.0 milestone Sep 30, 2020
@tombuildsstuff
Copy link
Contributor

Tests pass:

Screenshot 2020-09-30 at 10 31 08

@tombuildsstuff tombuildsstuff merged commit 6c56d02 into hashicorp:master Sep 30, 2020
tombuildsstuff added a commit that referenced this pull request Sep 30, 2020
@r0bnet r0bnet deleted the bump-iothub-api-version branch October 1, 2020 18:39
@ghost
Copy link

ghost commented Oct 1, 2020

This has been released in version 2.30.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.30.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Oct 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants