Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_cosmosdb_mongo_database doesn't call get throughput api when cosmos account is serverless #8673

Merged
merged 6 commits into from
Nov 5, 2020

Conversation

yupwei68
Copy link
Contributor

Fix #8661

=== RUN TestAccAzureRMCosmosDbMongoDatabase_basic
=== PAUSE TestAccAzureRMCosmosDbMongoDatabase_basic
=== CONT TestAccAzureRMCosmosDbMongoDatabase_basic
--- PASS: TestAccAzureRMCosmosDbMongoDatabase_basic (1726.68s)
=== RUN TestAccAzureRMCosmosDbMongoDatabase_complete
=== PAUSE TestAccAzureRMCosmosDbMongoDatabase_complete
=== CONT TestAccAzureRMCosmosDbMongoDatabase_complete
--- PASS: TestAccAzureRMCosmosDbMongoDatabase_complete (1794.50s)
=== RUN TestAccAzureRMCosmosDbMongoDatabase_autoscale
=== PAUSE TestAccAzureRMCosmosDbMongoDatabase_autoscale
=== CONT TestAccAzureRMCosmosDbMongoDatabase_autoscale
--- PASS: TestAccAzureRMCosmosDbMongoDatabase_autoscale (2084.84s)
=== RUN TestAccAzureRMCosmosDbMongoDatabase_serverless
=== PAUSE TestAccAzureRMCosmosDbMongoDatabase_serverless
=== CONT TestAccAzureRMCosmosDbMongoDatabase_serverless
--- PASS: TestAccAzureRMCosmosDbMongoDatabase_serverless (1724.47s)

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from one comment this LGTM 👍

@yupwei68 yupwei68 closed this Oct 9, 2020
@yupwei68 yupwei68 reopened this Oct 9, 2020
@yupwei68
Copy link
Contributor Author

yupwei68 commented Oct 9, 2020

@katbyte Thanks for your comments. Please continue reviewing.

@ghost ghost removed the waiting-response label Oct 9, 2020
@jackofallops jackofallops added this to the v2.34.0 milestone Oct 28, 2020
@jackofallops
Copy link
Member

Hi @yupwei68

Which region/location are you running this test in? It fails on the test suite with:

Error: Error creating CosmosDB Account "acctest-ca-201028162029940851" (Resource Group "acctestRG-cosmos-201028162029940851"): Error creating/updating CosmosDB Account "acctest-ca-201028162029940851" (Resource Group "acctestRG-cosmos-201028162029940851"): documentdb.DatabaseAccountsClient#CreateOrUpdate: Failure sending request: StatusCode=400 -- Original Error: Code="BadRequest" Message="EnableServerless is not valid for Mongo accounts with ServerVersion equal to 3.2.\r\nActivityId: eb658304-a4ef-455b-821f-6dc4e56adeae, Microsoft.Azure.Documents.Common/2.11.0"```

`MongoDBv3.4` capability appears to create a `v3.2` service?

@yupwei68
Copy link
Contributor Author

yupwei68 commented Nov 4, 2020

Hi @jackofallops Previously it worked. Currently I've updated the acctest to get it passed with mongo version 3.6.
=== RUN TestAccAzureRMCosmosDbMongoDatabase_serverless
=== PAUSE TestAccAzureRMCosmosDbMongoDatabase_serverless
=== CONT TestAccAzureRMCosmosDbMongoDatabase_serverless
--- PASS: TestAccAzureRMCosmosDbMongoDatabase_serverless (1548.01s)

@ghost ghost removed the waiting-response label Nov 4, 2020
@yupwei68 yupwei68 requested a review from katbyte November 4, 2020 08:10
@jackofallops
Copy link
Member

Tests passing:
image

Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the comments / changes @yupwei68 - LGTM now 👍

@jackofallops jackofallops merged commit 7d60c91 into hashicorp:master Nov 5, 2020
jackofallops added a commit that referenced this pull request Nov 5, 2020
@yupwei68 yupwei68 deleted the wyp-cos-to branch November 5, 2020 07:09
@ghost
Copy link

ghost commented Nov 5, 2020

This has been released in version 2.35.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.35.0"
}
# ... other configuration ...

@mariussm
Copy link
Contributor

mariussm commented Nov 6, 2020

Hi, the same issue exists for azurerm_cosmosdb_sql_database

@ghost
Copy link

ghost commented Dec 5, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error reading or replacing throughput from CosmosDB serverless database
4 participants