New data source azurerm_images

[ArcturusZhang]

Partially helps #8417

[manicminer]

Hi @ArcturusZhang, thanks for this PR!

Overall this looks great and I have just a few minor suggestions, however I'm not convinced that it addresses the linked issue? Could you look at adding the tags_filter attribute to the azurerm_image resource too?

[ArcturusZhang]

Hi @manicminer thanks for the review. I will get the comments resolved soon.

And to clarify,

Could you look at adding the tags_filter attribute to the azurerm_image resource too?

Do you mean that we need to add tags_filter to the azurerm_image data source?

[manicminer]

Do you mean that we need to add tags_filter to the azurerm_image data source?

Sorry, that is indeed what I meant :)

[ArcturusZhang]

Hi @manicminer I have made some changes, please have a look.

I do not think we should do too many things in one PR, therefore I might create another PR to add tags_filter for the azurerm_image data source. And I changed the description so that this PR will not close the coresponding issue.

[manicminer]

@ArcturusZhang This looks good to me, just one small change needed for tests to pass and then we can get this merged. Thanks!

[ArcturusZhang]

Hi @manicminer I have resolved the comment, could you please have a look again? thanks

[manicminer]

Test results:

[ghost]

This has been released in version 2.35.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.35.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!