Update azurerm_linux|windows_virtual_machine_scale_set - Fix #8422

[ArcturusZhang]

Fixes #8422

[ArcturusZhang]

New test case is passing:

=== RUN   TestAccAzureRMLinuxVirtualMachineScaleSet_otherVmExtensionsOnlySettings
=== PAUSE TestAccAzureRMLinuxVirtualMachineScaleSet_otherVmExtensionsOnlySettings
=== CONT  TestAccAzureRMLinuxVirtualMachineScaleSet_otherVmExtensionsOnlySettings
--- PASS: TestAccAzureRMLinuxVirtualMachineScaleSet_otherVmExtensionsOnlySettings (359.83s)
PASS

[jackofallops]

Hi @ArcturusZhang
Thanks for this, just a couple of really minor changes but otherwise LGTM 👍

[ArcturusZhang]

Hi @jackofallops thanks for the review, I have made some changes please have a look, thanks

[ArcturusZhang]

And @jackofallops rather than doing this patch on this particular resource, maybe an update to the structure.ExpandJsonFromString to make it could accept an empty string is a better idea?

We have almost exactly the same issue here: #8668

[jackofallops]

I had considered this, but changing that behaviour is likely to have unexpected effects elsewhere (such as potentially sending empty values where nil is expected). I think the current approach is appropriate for the time being, and is within our immediate domain of control, rather than changing the plugin-sdk.

[jackofallops]

Thanks @ArcturusZhang - LGTM now 👍

[ghost]

This has been released in version 2.30.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.30.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!