Adds new resource for azurerm_security_center_auto_provisioning #8595
Conversation
There was a problem hiding this comment.
Hi @benc-uk
Thanks for this PR, looking good so far, there's a few comments/questions below.
Could you add the docs for this new resource too?
azurerm/internal/services/securitycenter/azurerm_security_center_auto_provisioning.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/securitycenter/azurerm_security_center_auto_provisioning.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/securitycenter/azurerm_security_center_auto_provisioning.go
Outdated
Show resolved
Hide resolved
Client version bump to v3.0 Delete now resets API to "Off" setting Checking for empty resp.ID Removed pointless name variable
|
Hey @jackofallops all good suggestions, make all the changes plus a couple of other v minor improvements |
|
Tests passing (1 fail unrelated) |
|
This has been released in version 2.34.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.34.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
As per the proposal in issue #8550 this adds a new subscription level resource
azurerm_security_center_auto_provisioningin order to support the auto provisioning feature of Security CenterIncludes tests, which have been run and pass
Fixes #8550