Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_app_service && azurerm_function_app - don't try to manage source_control when scm_type is VSTSRM #8531

Merged
merged 4 commits into from
Sep 21, 2020

Conversation

jackofallops
Copy link
Member

resolves #8171

This change will prevent Terraform from resetting the site_config.scm_type value and updating the source_control block for Apps and Function Apps that have been updated/deployed after creation by Azure Devops.

!> Note: The side effect of this is that the resource cannot be used to create VSTSRM based apps directly.

@jackofallops jackofallops requested a review from a team September 18, 2020 14:20
@ghost ghost added the size/XS label Sep 18, 2020
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple of minor points but this otherwise LGTM 👍

azurerm/internal/services/web/resource_arm_app_service.go Outdated Show resolved Hide resolved
azurerm/internal/services/web/resource_arm_function_app.go Outdated Show resolved Hide resolved
@tombuildsstuff
Copy link
Contributor

Tests look good 👍

@tombuildsstuff tombuildsstuff added this to the v2.29.0 milestone Sep 21, 2020
@tombuildsstuff tombuildsstuff merged commit 0a92989 into master Sep 21, 2020
@tombuildsstuff tombuildsstuff deleted the b/app-service-ado-bug branch September 21, 2020 13:55
tombuildsstuff added a commit that referenced this pull request Sep 21, 2020
@ghost
Copy link

ghost commented Sep 24, 2020

This has been released in version 2.29.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.29.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Oct 21, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_app_service transient error - "RepoUrl VSTSRM is not supported"
3 participants