azurerm_logic_app_workflow - support for integration_service_environment_id #8504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Separate work done by @jackofallops on #8315 to unblock workflow ISE property, while integration account is waiting on upstream fix.
|
@jackofallops Since these are all your changes ad verbum, I would appreciate it a lot if you could give it a glance and maybe ship with 2.28? Thanks! |
tombuildsstuff
suggested changes
Sep 23, 2020
There was a problem hiding this comment.
hey @favoretti
Thanks for this PR :)
Taking a look through this mostly LGTM - if we can fix up the minor comments then this should otherwise be good to merge 👍
Thanks!
Co-authored-by: Tom Harvey <[email protected]>
Co-authored-by: Tom Harvey <[email protected]>
Co-authored-by: Tom Harvey <[email protected]>
|
@favoretti running the tests for this - all of the integration service environment tests are failing with: Which I believe is due to these: https://github.com/terraform-providers/terraform-provider-azurerm/blob/07b3926964c9792419206c2dac6af1ab0b60dfbf/azurerm/internal/services/logic/tests/integration_service_environment_resource_test.go#L134 - would you be able to move those from the ISE tests and we should be able to re-run those? Thanks! |
|
Hmm, I'm not sure I follow. Why would that start failing all of a sudden? And by "move" you mean make it accept empty plans? Would not that break anything else? |
|
@tombuildsstuff Pushed a commit removing those.. I'll run acceptance tests here locally as well to see if it works. |
|
@tombuildsstuff I ran acceptance tests locally, one failed, but really due to ISE's being slow, the rest passed: Normal tests failed on website-test transient tooling install error. Would you be so kind to retrigger both? |
|
Tests pass:
|
katbyte
changed the title
katbyte
added a commit
that referenced
this pull request
Sep 25, 2020
|
This has been released in version 2.30.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.30.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate work done by @jackofallops on #8315 to unblock workflow ISE
property, while integration account is waiting on upstream fix.