Bug: azurerm_windows_virtual_machine and azurerm_linux_virtual_machine - Add WaitForState on VM delete
#8383
Conversation
WodansSon
added
bug
service/virtual-machine
upstream/microsoft
| // disks have actually been deleted. | ||
|
|
||
| log.Printf("[INFO] verifying Linux Virtual Machine %q has been deleted", id.Name) | ||
| virtualMachine, _ := client.Get(ctx, id.ResourceGroup, id.Name, "") |
There was a problem hiding this comment.
we should still check this error here, should network issues/an outage happen or something this could be an error
| // disks have actually been deleted. | ||
|
|
||
| log.Printf("[INFO] verifying Windows Virtual Machine %q has been deleted", id.Name) | ||
| virtualMachine, _ := client.Get(ctx, id.ResourceGroup, id.Name, "") |
There was a problem hiding this comment.
we should still check this error here, should network issues/an outage happen or something this could be an error
|
Test failures are not related to my change: |
|
This has been released in version 2.27.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.27.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
This PR is a fix for the below Issue:
Today customer(s) deletes and then recreates a VM with the same name through Terraform and sometimes the “re-create” PUT gets blocked for a while as ARM hasn’t finished cleaning up the original deleted resources. This comes down to the reality that ARM considers a resource “deleted” not only when the delete job is done but also when a GET returns 404 and if that GET happens after the “re-create” PUT ARM will miss the 404.