Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/cognitive_account: fixing a crash & supporting AnomalyDetector / QnAMaker #8357

Merged
merged 3 commits into from
Sep 10, 2020

Conversation

tombuildsstuff
Copy link
Contributor

Fixes a crash when provisioning a QnAMaker and supports AnomalyDetector

Fixes #8355
Fixes #7662

Copy link
Contributor

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Edit: I added the same defence to the update func

@manicminer
Copy link
Contributor

Tests pass:

Screenshot 2020-09-07 at 12 24 09

12:00:49 [:~/go/src/github.com/terraform-providers/terraform-provider-azurerm]↥ pr/8357 2 ± ARM_TEST_LOCATION=westus make testacc TEST=./azurerm/internal/services/cognitive/tests TESTARGS="-run TestAccAzureRMCognitiveAccount_qnaRuntimeEndpoint"
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test ./azurerm/internal/services/cognitive/tests -v -run TestAccAzureRMCognitiveAccount_qnaRuntimeEndpoint -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccAzureRMCognitiveAccount_qnaRuntimeEndpoint
=== PAUSE TestAccAzureRMCognitiveAccount_qnaRuntimeEndpoint
=== RUN   TestAccAzureRMCognitiveAccount_qnaRuntimeEndpointUnspecified
=== PAUSE TestAccAzureRMCognitiveAccount_qnaRuntimeEndpointUnspecified
=== CONT  TestAccAzureRMCognitiveAccount_qnaRuntimeEndpoint
=== CONT  TestAccAzureRMCognitiveAccount_qnaRuntimeEndpointUnspecified
--- PASS: TestAccAzureRMCognitiveAccount_qnaRuntimeEndpointUnspecified (64.13s)
--- PASS: TestAccAzureRMCognitiveAccount_qnaRuntimeEndpoint (131.70s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/cognitive/tests	132.750s

@manicminer manicminer requested a review from a team September 7, 2020 13:17
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jackofallops jackofallops merged commit 668643e into master Sep 10, 2020
@jackofallops jackofallops deleted the b/cognitive-qna-crash branch September 10, 2020 10:19
jackofallops added a commit that referenced this pull request Sep 10, 2020
@ghost
Copy link

ghost commented Sep 10, 2020

This has been released in version 2.27.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.27.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Oct 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants