-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for VMSS in-line extensions behind feature flag #8222
Conversation
d1fb1c8
to
12243bb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @jackofallops
Thanks for this PR - I've taken a look through and left some comments inline - but this is off to a good start. If we can fix those up then we should be able to take another look and get this merged 👍🏻
Thanks!
azurerm/internal/services/compute/linux_virtual_machine_scale_set_resource.go
Outdated
Show resolved
Hide resolved
extensionProfile := expandVirtualMachineScaleSetExtensions(d.Get("extension").([]interface{})) | ||
updateProps.VirtualMachineProfile.ExtensionProfile = extensionProfile | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(not an issue, for info) since this is using d.HasChange
this should support mixing both the inline and external resource here as required
azurerm/internal/services/compute/linux_virtual_machine_scale_set_resource.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left a few comments inline but this otherwise otherwise LGTM 👍
azurerm/internal/services/compute/linux_virtual_machine_scale_set_resource.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments inline but this otherwise LGTM 👍
examples/service-fabric/windows-vmss-self-signed-certs/README.md
Outdated
Show resolved
Hide resolved
examples/service-fabric/windows-vmss-self-signed-certs/3-servicefabric.tf
Outdated
Show resolved
Hide resolved
6b2f42e
to
603ee9b
Compare
This has been released in version 2.26.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.26.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
This PR adds beta support for adding VM Extensions to
azurerm_linux_virtual_machine_scale_set
andazurerm_windows_virtual_machine_scale_set
Set the env var
ARM_PROVIDER_VMSS_EXTENSIONS_BETA
to anything but an empty string to enableresolves #5976
Adds example of Service Fabric with VMSS + inline extension.
TODO's