Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

locations: patching the india location names #8217

Merged
merged 1 commit into from
Aug 24, 2020

Conversation

tombuildsstuff
Copy link
Contributor

The Azure API returns these incorrectly (e.g. "indiasouth" instead of "southindia") so until that's resolved we need to patch these if running in Azure Public

Fixes #7906

The Azure API returns these incorrectly (e.g. "indiasouth" instead of "southindia")
so until that's resolved we need to patch these if running in Azure Public
@tombuildsstuff tombuildsstuff added bug upstream/microsoft Indicates that there's an upstream issue blocking this issue/PR provider labels Aug 24, 2020
@tombuildsstuff tombuildsstuff added this to the v2.25.0 milestone Aug 24, 2020
@ghost ghost added the size/S label Aug 24, 2020
@tombuildsstuff tombuildsstuff requested a review from a team August 24, 2020 10:39
Copy link
Contributor

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@tombuildsstuff tombuildsstuff merged commit 765d624 into master Aug 24, 2020
@tombuildsstuff tombuildsstuff deleted the b/patch-india-locations branch August 24, 2020 16:20
tombuildsstuff added a commit that referenced this pull request Aug 24, 2020
@ghost
Copy link

ghost commented Aug 27, 2020

This has been released in version 2.25.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.25.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Sep 24, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug provider size/S upstream/microsoft Indicates that there's an upstream issue blocking this issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terraform and Azure API locations inconsistency
2 participants