Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add doc and test to support function app slot vnet connetion - "azurerm_app_service_slot_virtual_network_swift_connection" #8111

Merged
merged 3 commits into from
Aug 24, 2020

Conversation

njuCZ
Copy link
Contributor

@njuCZ njuCZ commented Aug 13, 2020

fix #8048

because app service and function app are one rest api, resource "azurerm_app_service_slot_virtual_network_swift_connection" also applies to "azurerm_function_app_slot". this PR add test and doc for function app part

@njuCZ njuCZ changed the title add doc and test for support function app slot vnet connetion - "azurerm_app_service_slot_virtual_network_swift_connection" add doc and test to support function app slot vnet connetion - "azurerm_app_service_slot_virtual_network_swift_connection" Aug 13, 2020
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @njuCZ

Thanks for this PR :)

Taking a look through this mostly LGTM - if we can handle the errors here then this otherwise LGTM 👍

Thanks!


* `slot_name` - (Required) The name of the App Service Slot. Changing this forces a new resource to be created.
* `slot_name` - (Required) The name of the App Service Slot or Function App Slot. Changing this forces a new resource to be created.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whilst these are shared today - longer-term we'll likely want to introduce an alias for the function app resources

this isn't a big deal right now, and these do technically work - but we'll probably look to add aliases for these resources in 3.0 - since (based on Github issues) folks appear to be unaware these are the same thing

@njuCZ
Copy link
Contributor Author

njuCZ commented Aug 24, 2020

@tombuildsstuff I have added back the error check, could you please have a look again?

@ghost ghost removed the waiting-response label Aug 24, 2020
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for pushing those changes @njuCZ

@tombuildsstuff tombuildsstuff added this to the v2.25.0 milestone Aug 24, 2020
@tombuildsstuff
Copy link
Contributor

Tests pass:

Screenshot 2020-08-24 at 16 04 01

@tombuildsstuff tombuildsstuff merged commit 4803db4 into hashicorp:master Aug 24, 2020
tombuildsstuff added a commit that referenced this pull request Aug 24, 2020
@ghost
Copy link

ghost commented Aug 27, 2020

This has been released in version 2.25.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.25.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Sep 23, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants