Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add signed_version attribute to azurerm_storage_account_sas #8020

Merged

Conversation

sschmeck
Copy link
Contributor

@sschmeck sschmeck commented Aug 5, 2020

Implements #7619

  • Should I add a proper version validator for signed_version?

@sschmeck sschmeck force-pushed the add_signed_version_to_account_sas branch from 5c53e23 to ab118db Compare August 5, 2020 14:23
@ghost ghost added size/XS and removed size/L labels Aug 5, 2020
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sschmeck! this LGTM, going to merge it now to get it into todays release, but if you want to open a new PR with validation for the version that would be great 🙂 thanks!

@katbyte katbyte added this to the v2.22.0 milestone Aug 6, 2020
@katbyte katbyte merged commit 6655311 into hashicorp:master Aug 6, 2020
katbyte added a commit that referenced this pull request Aug 6, 2020
@ghost
Copy link

ghost commented Aug 7, 2020

This has been released in version 2.22.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.22.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Sep 6, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants