d/api_management_user - updating the username validation

[rikribbers]

I fixed the retrieval of admin user.

Rationale for the fix:

I interpreted that the user_id field is the user identifier and not the full Azure resource id. The MS docs state that is the "User identifier" and it is unique within the current APIM instance. The type is string.

https://docs.microsoft.com/en-us/rest/api/apimanagement/2019-12-01/user/get

Fixes #3967

[tombuildsstuff]

hey @rikribbers

Thanks for this PR :)

Taking a look through here, is it possible to give an example of the username which is being rejected here? Based on what I can see in the validation code we're validating for a 3-80 character username, rather than a Resource ID - so I'm wondering if we need to update this regex instead?

Thanks!

[rikribbers]

ok, I understand the tradeoff that was made here.. was thinking about using a regex like this:

^(?!.*-$)^[a-z][a-z-]{0,79}$

However this uses a negative lookup that is not supported by go. So second best is to go for a length of 2:

^[a-zA-Z0-9])([a-zA-Z0-9-]{0,78})([a-zA-Z0-9]$

Or split the check up into 2 steps, one for starting and ending with a '-' character and a allowed character regex : ^[a-zA-Z0-9-]{1,80}

I could use some advice on what to implement. I prefer the last one. as this resembles the actual behaviour from the portal.

[katbyte]

Hey @rikribbers - the 2nd option would be fine :)

[tombuildsstuff]

LGTM - thanks for pushing those changes @rikribbers

[ghost]

This has been released in version 2.23.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.23.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!