new resource and data source for azurerm_synapse_workspace
#7517
Conversation
There was a problem hiding this comment.
@njuCZ, thank you so much for this PR and new resource!!!! This looks great, but I did add a few comments to the PR and would appreciate it if you could take a look. They are mostly minor, other than that this PR LGTM! Thanks so much for your work on this! Nice job! 🚀
azurerm/internal/services/synapse/synapse_workspace_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/synapse/synapse_workspace_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/synapse/synapse_workspace_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/synapse/synapse_workspace_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/synapse/validate/synapse_workspace.go
Outdated
Show resolved
Hide resolved
|
@WodansSon thanks for your suggestions, I have modifed this PR, could you please have a look again? |
There was a problem hiding this comment.
Hi @njuCZ
Thanks for addressing @WodansSon 's feedback, this now LGTM 👍
|
Tests pass: |
|
This has been released in version 2.20.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.20.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
first resource of #7406