Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_marketplace_agreement - fix issue around import #7515

Merged

Conversation

magodo
Copy link
Collaborator

@magodo magodo commented Jun 29, 2020

The import error message is incorrect, as this resource is using the
ID of agreement as its ID, it should use that ID to imform user to
import (while currently it is using the ID of term in the error
message).

In the meanwhile, modify some other log messages to convey the correct
intention.

Besides, fix a typo in another PR which fixes the import ID in the
document.

(fix: #7301)

The import error message is incorrect, as this resource is using the
ID of `agreement` as its ID, it should use that ID to imform user to
import (while currently it is using the ID of `term` in the error
message).

In the meanwhile, modify some other log messages to convey the correct
intention.

Besides, fix a typo in another PR which fixes the import ID in the
document.
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mbfrahry mbfrahry changed the title azurerm_marketplace_agreement: fix import issue azurerm_marketplace_agreement - fix issue around importing Jun 30, 2020
@mbfrahry mbfrahry changed the title azurerm_marketplace_agreement - fix issue around importing azurerm_marketplace_agreement - fix issue around import Jun 30, 2020
@mbfrahry mbfrahry added this to the v2.17.0 milestone Jun 30, 2020
@mbfrahry mbfrahry merged commit bb3d801 into hashicorp:master Jun 30, 2020
mbfrahry added a commit that referenced this pull request Jun 30, 2020
@ghost
Copy link

ghost commented Jul 3, 2020

This has been released in version 2.17.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.17.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jul 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_marketplace_agreement: publisher isn't correctly extracted from resource path
2 participants