Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for publicNetworkAccess property on resource azurerm_search_service #7255

Closed
jamiefrench opened this issue Jun 8, 2020 · 4 comments · Fixed by #7867
Closed

Support for publicNetworkAccess property on resource azurerm_search_service #7255

jamiefrench opened this issue Jun 8, 2020 · 4 comments · Fixed by #7867

Comments

@jamiefrench
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

This value can be set to 'enabled' to avoid breaking changes on existing customer resources and templates. If set to 'disabled', traffic over public interface is not allowed, and private endpoint connections would be the exclusive access method.

New or Affected Resource(s)

  • azurerm_search_service

Potential Terraform Configuration

resource "azurerm_search_service" "example" {
  name                            = "example-search-service"
  resource_group_name = azurerm_resource_group.example.name
  location                        = azurerm_resource_group.example.location
  sku                               = "standard"

  public_network_access = false
}

References

@lrxtom2
Copy link
Contributor

lrxtom2 commented Jun 10, 2020

@jamiefrench Hi, Thanks for opening the great issue! We are working on the go-sdk for implement the future. After new version go-sdk is released, we will implement it immediately. Thanks for that.

@lrxtom2
Copy link
Contributor

lrxtom2 commented Jun 12, 2020

@ghost
Copy link

ghost commented Jul 31, 2020

This has been released in version 2.21.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.21.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Aug 23, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants