Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the compute service api-version from 2019-07-01 to 2019-12-01 #7101

Merged
merged 11 commits into from
Jun 18, 2020

Conversation

ArcturusZhang
Copy link
Contributor

@ArcturusZhang ArcturusZhang commented May 27, 2020

Some functionalities in the azurerm_orchestrated_virtual_machine_scale_set requires 2019-12-01 to use.

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@katbyte katbyte added this to the v2.13.0 milestone Jun 1, 2020
@tombuildsstuff tombuildsstuff modified the milestones: v2.13.0, v2.14.0 Jun 4, 2020
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @ArcturusZhang

Taking a look through it appears there's a breaking change here? Whilst this property may no longer be necessary - going from "only true" to "only false" isn't a change we can ship outside of a major version unfortunately.

Thanks!

Type: schema.TypeBool,
Optional: true,
Default: false,
ValidateFunc: validateBoolIsFalse,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a breaking change - previously this could be set to true?

Copy link
Contributor

@fitzgeraldsteele fitzgeraldsteele Jun 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Tom, I'm the Microsoft PM behind this feature, working with @ArcturusZhang to expose to Terraform. I can confirm that for this preview feature, we changed from true to false to support an update of the technology stack. We don't have any customers using spg=true for this preview at the moment, but we do have customers waiting for spg=false.

Would it be ok to allow this value to be true or false, and just pass the value to Azure to do the validation? Happy to discuss or talk through whatever needed so that we can get this out ASAP

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fitzgeraldsteele - right now the property is forced to be true in terraform so anyone using the resource would have spg=true, and to date the previous API version still works with spg=true - are you saying absolutely no one is currently using orchestrated VMSSs via terraform at this time?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(its been released so anyone could be using it atm)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checking the usage data now. We are closing/discontinuing the preview that uses spg=true, and are working to unblock customers using spg=false. Our documentation will have this update. If we document that in the changelog here, can we bring this back into the 2.14 release?

Happy to have a non-github discussion...I don't want to post the usage data here. :) jerry steele @ microsoft

@tombuildsstuff tombuildsstuff added the service/vmss Virtual Machine Scale Sets label Jun 11, 2020
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank @ArcturusZhang - LGTM 👍

@katbyte katbyte merged commit 1a7f16d into hashicorp:master Jun 18, 2020
@ghost
Copy link

ghost commented Jun 19, 2020

This has been released in version 2.15.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.15.0"
}
# ... other configuration ...

@ArcturusZhang ArcturusZhang deleted the update-api-version-for-compute branch June 19, 2020 03:26
@ghost
Copy link

ghost commented Jul 19, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants