-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_app_service_certificate - support for hosting_environment_profile_id #7087
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the enhancement PR @wmdave - overall this looks good but could we update the docs with the new property and add this to a test? thanks!
azurerm/internal/services/web/resource_arm_app_service_certificate.go
Outdated
Show resolved
Hide resolved
I added a test for certificate creation in the ASE test cases (figured that was better than adding an ASE to certificate test cases). There's now a test failure on CI. Locally, I was relying on ARM_SUBSCRIPTION_ID to be set to help calculate the appropriate hosting_environment_profile for the certificate but apparently it's not for CI. I think I may just re-factor the change to require something like this:
I'm relatively sure that the ASE in question would have to be in the same subscription, so doing this makes the configuration a little cleaner. Only thing I don't like is that the original design leveraged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thats the place for the test! however i'm not entirely sure why you moved away from the single hosting_environment_id
property - the RG and ASE name would be a part of is as would the subscription ID?
The Open to changing back to a single property, if you think that's best. |
@wmdave - I do, you'd then be able to just us |
Okay, switched back and I think updated docs and test case. Passed locally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @wmdave! LGTM now
This has been released in version 2.15.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.15.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
No description provided.