-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] azurerm_redis_cache backup requires connection string #6819
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this fix @cemckenzie ! aside from 2 comments this looks good
698ed80
to
e0f9ba7
Compare
Co-authored-by: kt <[email protected]>
e0f9ba7
to
616f0d4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @cemckenzie! LGTM 👍
This has been released in version 2.9.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.9.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
When creating a redis-cache resource, the rdb-storage-connection-string in the redis_configuration is required is rdb_backup_enabled is true.
Currently, an error is thrown during the create:
redis.Client#Create: Failure sending request: StatusCode=400 -- Original Error: Code="InvalidRequestBody" Message="The value of the parameter 'properties.redisConfiguration.rdb-storage-connection-string' is invalid."
This change updates the error to:
Error: Error parsing Redis Configuration: The rdb_storage_connection_string property must be set when rdb_backup_enabled is true on <PATH>/main.tf line 23
It also updates the docs.