Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_private_endpoint: Add support for tags #6574

Merged
merged 2 commits into from
Apr 23, 2020

Conversation

neil-yechenwei
Copy link
Contributor

Fix the issue of #6544

@WodansSon WodansSon changed the title Add support for tags of private endpoint azurerm_private_endpoint: Add support for tags Apr 23, 2020
@WodansSon WodansSon added this to the v2.8.0 milestone Apr 23, 2020
Copy link
Collaborator

@WodansSon WodansSon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neil-yechenwei , thanks for the PR, LGTM 🚀

@WodansSon WodansSon modified the milestones: v2.8.0, v2.7.0 Apr 23, 2020
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@WodansSon
Copy link
Collaborator

image

@WodansSon WodansSon merged commit f0d313b into hashicorp:master Apr 23, 2020
WodansSon added a commit that referenced this pull request Apr 23, 2020
@ghost
Copy link

ghost commented Apr 23, 2020

This has been released in version 2.7.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.7.0"
}
# ... other configuration ...

@JamesDLD
Copy link

Does this also tags the network interface?

neil-yechenwei pushed a commit to neil-yechenwei/terraform-provider-azurerm that referenced this pull request Apr 26, 2020
* Add support for tags of private endpoint

* Fix test issue

Co-authored-by: Jeffrey Cline <[email protected]>
neil-yechenwei pushed a commit to neil-yechenwei/terraform-provider-azurerm that referenced this pull request Apr 26, 2020
@ghost
Copy link

ghost commented May 23, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators May 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants