Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource: azurerm_private_dns_txt_record #6309

Merged
merged 8 commits into from
Apr 8, 2020

Conversation

manicminer
Copy link
Contributor

Fixes #5012

@manicminer manicminer requested a review from katbyte March 31, 2020 14:32
@manicminer manicminer requested review from a team and removed request for katbyte April 1, 2020 10:58
@mbfrahry mbfrahry self-assigned this Apr 1, 2020
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great so far! I'm just calling out some areas we could simplify down and a little more test completeness

@manicminer manicminer force-pushed the manicminer/private-dns-txt-record branch from 39f1495 to 04a8d17 Compare April 7, 2020 12:18
@manicminer manicminer requested a review from mbfrahry April 7, 2020 14:27
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tombuildsstuff tombuildsstuff added this to the v2.5.0 milestone Apr 8, 2020
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff
Copy link
Contributor

Tests pass:

Screenshot 2020-04-08 at 14 28 04

@tombuildsstuff tombuildsstuff merged commit 6411380 into master Apr 8, 2020
@tombuildsstuff tombuildsstuff deleted the manicminer/private-dns-txt-record branch April 8, 2020 12:28
tombuildsstuff added a commit that referenced this pull request Apr 8, 2020
@ghost
Copy link

ghost commented Apr 9, 2020

This has been released in version 2.5.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.5.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented May 8, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators May 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for azurerm_private_dns_txt_record
4 participants