Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPC export mount_addresses #6214

Merged
merged 2 commits into from
Mar 23, 2020

Conversation

magodo
Copy link
Collaborator

@magodo magodo commented Mar 22, 2020

User need to use mount_addresses to be able to mount the hpc cache to other places.

💤  terraform-provider-azurerm [hpc_export_mount_addr] ⚡  make testacc TEST="./azurerm/internal/services/storage/tests" TESTARGS="-run='TestAccAzureRMHPCCache_basic'"    
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
TF_ACC=1 go test ./azurerm/internal/services/storage/tests -v -run='TestAccAzureRMHPCCache_basic' -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccAzureRMHPCCache_basic
=== PAUSE TestAccAzureRMHPCCache_basic
=== CONT  TestAccAzureRMHPCCache_basic
--- PASS: TestAccAzureRMHPCCache_basic (1811.48s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/storage/tests       1811.508s

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor clarification but this otherwise LGTM 👍

website/docs/r/hpc_cache.html.markdown Outdated Show resolved Hide resolved
@magodo
Copy link
Collaborator Author

magodo commented Mar 23, 2020

@tombuildsstuff
Thank you for quick review!

@tombuildsstuff tombuildsstuff merged commit d19d0e8 into hashicorp:master Mar 23, 2020
tombuildsstuff added a commit that referenced this pull request Mar 23, 2020
@ghost
Copy link

ghost commented Mar 27, 2020

This has been released in version 2.3.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.3.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Apr 22, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants