CDN Endpoint Delivery Rules #6163
Conversation
…l redirect action and request scheme condition
# Conflicts: # vendor/modules.txt
Fixed Usage definition: resource_group >> resource_group_name
This tools intended to aid with building new resources, in particular by scaffolding the documentation from the resource definition. Note: this is intentionally scaffolding - not full codegen - since documentation should always require human review for clarity / grammar.
…e no longer forcenew
The temporary patch in the provider/test suite allows for us to gradually add provider blocks to the test suite, rather than doing it in a big-bang (and breaking open PR's). Unfortunately this workaround was unintentionally available in release binaries, as such this commit changes this patch to only work for test providers rather than released versions since this isn't intended to be used by users. Instead we require that Provider blocks and Feature blocks are both specified to be explicit about which instance of a provider is being used when provisioning resources.
|
Any chance this could make it into the next release? |
There was a problem hiding this comment.
hey @r0bnet
Thanks for this PR :)
Taking a look through I've left some comments inline but this mostly LGTM - I hope you don't mind but I'm going to push a few commits to fix up the pending comments/refactor this to match the other resources, but 🤞 we can get this into the v2.6 release :)
Thanks!
azurerm/internal/services/cdn/deliveryruleactions/cache_expiration.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/cdn/deliveryruleactions/cache_key_query_string.go
Show resolved
Hide resolved
|
Ignoring quota issues in Azure, the tests pass 👍 |
|
This has been released in version 2.6.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.6.0"
}
# ... other configuration ... |
|
Thank you! I was waiting for this feature. I found one small issue when working with it. Terraform plan always shows that a request_header_condition is about to be added even if it has been added previously and there were no changes in between. I used some other actions and conditions and they work fine. |
|
Hey @krzyszt0fd, |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Didn't see a request for that yet but we personally have some use cases for it. It implements the CDN rules engine that
Standard_MicrosoftCDN profiles offer.Documentation: https://docs.microsoft.com/en-us/rest/api/cdn/endpoints/create#deliverypolicy