Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AD domain regex for azure netapp files account to allow dash (-) #5842

Merged
merged 1 commit into from
Feb 23, 2020
Merged

Conversation

jknash
Copy link
Contributor

@jknash jknash commented Feb 21, 2020

Azure AD domain services allows a dash - in the domain name, but the regex that validates the domain name does not. I changed the regex from: ^[(\da-zA-Z).]{1,255}$
to: ^[(\da-zA-Z-).]{1,255}$
It's a subtle change, but we can't use the ANF provider until it is fixed, because our domain name contains a dash -

Azure AD domain services allows a dash - in the domain name, but the regex that validates the domain name does not.  I changed the regex from: ^[(\da-zA-Z)\.]{1,255}$ 
to:  ^[(\da-zA-Z-)\.]{1,255}$
It's a subtle change, but we can't use the ANF provider until it is fixed, because our domain name contains a dash -
@ghost ghost added the size/XS label Feb 21, 2020
@jknash
Copy link
Contributor Author

jknash commented Feb 23, 2020

Looking at this, I should have said this is for the azure netapp files account resource in the title. It's not immediately clear. Sorry!

@jknash jknash changed the title Update domain regex to allow dash (-) Update AD domain regex for azure netapp files account to allow dash (-) Feb 23, 2020
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this @jknash

@tombuildsstuff tombuildsstuff added this to the v2.0.0 milestone Feb 23, 2020
@tombuildsstuff tombuildsstuff merged commit cb94cc1 into hashicorp:master Feb 23, 2020
tombuildsstuff added a commit that referenced this pull request Feb 23, 2020
@ghost
Copy link

ghost commented Feb 24, 2020

This has been released in version 2.0.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.0.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants