Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New data source: 'azurerm_eventhub_authorization_rule' #5805

Merged

Conversation

jackbatzner
Copy link
Contributor

=== RUN TestAccDataSourceAzureRMEventHubAuthorizationRule
=== PAUSE TestAccDataSourceAzureRMEventHubAuthorizationRule
=== CONT TestAccDataSourceAzureRMEventHubAuthorizationRule
--- PASS: TestAccDataSourceAzureRMEventHubAuthorizationRule (291.84s)
PASS
ok github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/eventhub/tests 292.144s

=== RUN   TestAccDataSourceAzureRMEventHubAuthorizationRule
=== PAUSE TestAccDataSourceAzureRMEventHubAuthorizationRule
=== CONT  TestAccDataSourceAzureRMEventHubAuthorizationRule
--- PASS: TestAccDataSourceAzureRMEventHubAuthorizationRule (291.84s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/eventhub/tests      292.144s
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this @Brunhil

@tombuildsstuff
Copy link
Contributor

The Travis build failure is unrelated (and has been fixed via #5807) - this should be fine 👍

@tombuildsstuff tombuildsstuff merged commit b132923 into hashicorp:master Feb 18, 2020
tombuildsstuff added a commit that referenced this pull request Feb 18, 2020
@ghost
Copy link

ghost commented Feb 24, 2020

This has been released in version 2.0.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.0.0"
}
# ... other configuration ...

@jackbatzner jackbatzner deleted the eventhub_auth_rule_datasource branch March 14, 2020 14:48
@ghost
Copy link

ghost commented Mar 20, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants