-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an option to filter out preview aks releases when fetching versions #5662
Add an option to filter out preview aks releases when fetching versions #5662
Conversation
|
ea30251
to
2a56a48
Compare
Rebased against the released version and ran a test locally:
|
2a56a48
to
6c56d41
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @matthewi
Thanks for this PR :)
Taking a look through this mostly LGTM - if we can fix up the minor comments (and resolve the website travis issue by rebasing) then this should otherwise be good 👍
Thanks!
azurerm/internal/services/containers/data_source_kubernetes_service_version.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/containers/data_source_kubernetes_service_version.go
Outdated
Show resolved
Hide resolved
6c56d41
to
7ec224a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @matthewi
Thanks for pushing those changes - I've left a couple of comments regarding the documentation but this otherwise LGTM 👍
Thanks!
lintrest and tflint pass on my machine. We'll see what Travis does this time 🤞 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
This has been released in version 2.0.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.0.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
No description provided.