New Resource: azurerm_iotcentral_application #5446

xuzhang3 · 2020-01-20T06:57:31Z

No description provided.

…tral

katbyte

thanks for the pr @xuzhang3! I've left some comments inline that need to be addressed before merging

azurerm/internal/services/iotcentral/resource_arm_iotcentral_application.go

katbyte · 2020-01-25T18:13:00Z

azurerm/internal/services/iotcentral/resource_arm_iotcentral_application.go

+		return fmt.Errorf("Error setting `sku`:  %+v", err)
+	}
+
+	d.Set("sub_domain", resp.AppProperties.Subdomain)


We should nil check here:

if props := resp.AppProperties; props != nil { d.Set("sub_domain", props.Subdomain) ...

azurerm/internal/services/iotcentral/resource_arm_iotcentral_application.go

katbyte · 2020-01-25T18:14:58Z

azurerm/internal/services/iotcentral/resource_arm_iotcentral_application.go

+	name := d.Get("name").(string)
+	resourceGroup := d.Get("resource_group_name").(string)


We'll need to parse the ID here. An example of this can be found in this PR: #5409

fixed. add parseId function

azurerm/internal/services/iotcentral/resource_arm_iotcentral_application.go

katbyte · 2020-01-25T18:16:44Z

azurerm/internal/services/iotcentral/tests/resource_arm_iotcentral_application_test.go

+func testAccAzureRMIotCentralApplication_basic(data acceptance.TestData) string {
+	return fmt.Sprintf(`
+resource "azurerm_resource_group" "test" {
+  name     = "acctestRG-%[2]d"


Could we use

Suggested change

name = "acctestRG-%[2]d"

name = "acctestRG-iotc-%[1]d"

the first indexed argument should be 1

katbyte · 2020-01-25T18:17:14Z

azurerm/internal/services/iotcentral/tests/resource_arm_iotcentral_application_test.go

+  sku                 = "S1"
+  template            = "[email protected]"
+  tags = {
+


Suggested change

katbyte · 2020-01-25T18:18:20Z

azurerm/internal/services/iotcentral/validate/iotcentral_app_test.go

+		"a1", "11", "1a", "aa",
+		"1-1", "aaa-aa", "a--a-aa",
+		"a1-1", "a1-a", "1a-1", "1a-a-1-2",
+		"abcdeabcdeabcdeabcdeabcdeabcdeabcdeabcdeabcdeabcdeabcdeabcde",
+		"abcdeabcdeabcdeabcdeabcdeabcdeabcdeabcdeabcdeabcdeabcdeabcde123",


Could we make this consistent with other validation tests in the provideR?

katbyte · 2020-01-25T18:18:43Z

website/docs/r/iotcentral_application.html.markdown

+
+The following attributes are exported:
+
+* `id` - The ID of the IoTCentralApplication.


Suggested change

* `id` - The ID of the IoTCentralApplication.

* `id` - The ID of the IoT Central Application.

katbyte · 2020-01-25T18:18:52Z

website/docs/r/iotcentral_application.html.markdown

+IoTCentralApplication can be imported using the `resource id`, e.g.
+
+```shell
+terraform import azurerm_iotcentral_application.app1 /subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/mygroup1/providers/Microsoft.IoTCentral/IoTApps/app1


Suggested change

terraform import azurerm_iotcentral_application.app1 /subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/mygroup1/providers/Microsoft.IoTCentral/IoTApps/app1

terraform import azurerm_iotcentral_application.example /subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/mygroup1/providers/Microsoft.IoTCentral/IoTApps/app1

…tral

xuzhang3 · 2020-02-17T07:17:00Z

fixed review code problems

…tral

katbyte

Hi @xuzhang3,

I tried to run the tests for this today and got the following error:

[12:28:41] kt@katbook:~/hashi/tf/azure/azurerm▸f/resource_iotcentral$ testazure TestAccAzureRMIoTCentralApplication
==> Fixing source code with gofmt...
# This logic should match the search logic in scripts/gofmtcheck.sh
find . -name '*.go' | grep -v vendor | xargs gofmt -s -w
# github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/provider
azurerm/internal/provider/services.go:96:26: cannot use "github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/iotcentral".Registration literal (type "github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/iotcentral".Registration) as type "github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/common".ServiceRegistration in array or slice literal:
	"github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/iotcentral".Registration does not implement "github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/common".ServiceRegistration (missing WebsiteCategories method)
FAIL	github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/iotcentral/tests [build failed]

I don't have permission to your branch so would you mind merging master and fixing the test? thanks!

…tral # Conflicts: # azurerm/internal/clients/client.go

xuzhang3 · 2020-03-06T13:39:14Z

fix gofmtcheck.sh test issue

katbyte

Thanks for the revisions @xuzhang3! LGTM now

ghost · 2020-03-11T21:37:04Z

This has been released in version 2.1.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.1.0"
}
# ... other configuration ...

ghost · 2020-04-06T14:50:06Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

xuzhang3 added 7 commits January 17, 2020 15:28

new resource IoTCentral application

aa98459

IoTCentral application. and docs to azure.erb

c693645

Merge remote-tracking branch 'upstream/master' into f/resource_iotcen…

627a007

…tral

azure-go-sdk refresh

f57368e

iot central app

9728aad

Merge remote-tracking branch 'upstream/master' into f/resource_iotcen…

3aa5961

…tral

iot central app

d686fc7

ghost added size/XXL dependencies documentation labels Jan 20, 2020

xuzhang3 added 2 commits January 20, 2020 16:51

fix CI issues

c61f0a8

fix CI format issues,

6c3267a

katbyte requested changes Jan 25, 2020

View reviewed changes

katbyte added service/iot-central new-resource waiting-response labels Jan 25, 2020

katbyte added this to the v1.43.0 milestone Jan 25, 2020

tombuildsstuff removed this from the v1.43.0 milestone Feb 3, 2020

xuzhang3 added 3 commits February 4, 2020 13:56

Merge remote-tracking branch 'upstream/master' into f/resource_iotcen…

c91e66c

…tral

fix code review problem

5dc9fbb

Merge remote-tracking branch 'upstream/master' into f/resource_iotcen…

942aa6c

…tral

xuzhang3 requested a review from katbyte February 4, 2020 16:36

ghost removed the waiting-response label Feb 17, 2020

Merge remote-tracking branch 'upstream/master' into f/resource_iotcen…

f6a0d52

…tral

katbyte added this to the v2.1.0 milestone Mar 2, 2020

katbyte requested changes Mar 4, 2020

View reviewed changes

katbyte added the waiting-response label Mar 4, 2020

Merge remote-tracking branch 'upstream/master' into f/resource_iotcen…

4d409e8

…tral # Conflicts: # azurerm/internal/clients/client.go

ghost removed the waiting-response label Mar 6, 2020

katbyte added 3 commits March 6, 2020 10:23

Rename app_configuration.go to iotcentral_application.go

807cf42

Rename app_configuration_test.go to iotcentral_application_test.go

d974d01

Update resource_arm_iotcentral_application_test.go

b7795f9

katbyte approved these changes Mar 6, 2020

View reviewed changes

katbyte merged commit 70915ec into hashicorp:master Mar 6, 2020

katbyte changed the title ~~New Resource: IoTCentralApplocation~~ New Resource: azurerm_iotcentral_application Mar 6, 2020

katbyte added a commit that referenced this pull request Mar 6, 2020

Update CHANGELOG.md to include #5446

920c207

ghost locked and limited conversation to collaborators Apr 6, 2020

xuzhang3 deleted the f/resource_iotcentral branch August 14, 2024 02:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Resource: azurerm_iotcentral_application #5446

New Resource: azurerm_iotcentral_application #5446

xuzhang3 commented Jan 20, 2020

katbyte left a comment

katbyte Jan 25, 2020

xuzhang3 Feb 4, 2020

katbyte Jan 25, 2020

xuzhang3 Feb 4, 2020

katbyte Jan 25, 2020

xuzhang3 Feb 4, 2020

katbyte Jan 25, 2020

xuzhang3 Feb 4, 2020

katbyte Jan 25, 2020

xuzhang3 Feb 4, 2020

katbyte Jan 25, 2020

xuzhang3 Feb 4, 2020

katbyte Jan 25, 2020

xuzhang3 Feb 4, 2020

xuzhang3 commented Feb 17, 2020

katbyte left a comment

xuzhang3 commented Mar 6, 2020

katbyte left a comment

ghost commented Mar 11, 2020

ghost commented Apr 6, 2020

		name := d.Get("name").(string)
		resourceGroup := d.Get("resource_group_name").(string)


		The following attributes are exported:

		* `id` - The ID of the IoTCentralApplication.

	* `id` - The ID of the IoTCentralApplication.
	* `id` - The ID of the IoT Central Application.

	terraform import azurerm_iotcentral_application.app1 /subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/mygroup1/providers/Microsoft.IoTCentral/IoTApps/app1
	terraform import azurerm_iotcentral_application.example /subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/mygroup1/providers/Microsoft.IoTCentral/IoTApps/app1

New Resource: azurerm_iotcentral_application #5446

New Resource: azurerm_iotcentral_application #5446

Conversation

xuzhang3 commented Jan 20, 2020

katbyte left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

xuzhang3 commented Feb 17, 2020

katbyte left a comment

Choose a reason for hiding this comment

xuzhang3 commented Mar 6, 2020

katbyte left a comment

Choose a reason for hiding this comment

ghost commented Mar 11, 2020

ghost commented Apr 6, 2020